On Mon, Oct 24, 2022 at 11:24:07PM +0200, Nam Cao wrote: > The function _r8712_init_recv_priv() and also r8712_init_recv_priv() > just returns silently if they fail to allocate memory. Change their > return type to int and add necessary checks and handling if they return > -ENOMEM > > Signed-off-by: Nam Cao <namcaov@xxxxxxxxx> > --- > drivers/staging/rtl8712/os_intfs.c | 3 ++- > drivers/staging/rtl8712/recv_osdep.h | 8 ++++---- > drivers/staging/rtl8712/rtl8712_recv.c | 7 ++++--- > drivers/staging/rtl8712/rtl871x_recv.c | 13 +++++++++---- > 4 files changed, 19 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c > index 003e97205124..47d7d998fa86 100644 > --- a/drivers/staging/rtl8712/os_intfs.c > +++ b/drivers/staging/rtl8712/os_intfs.c > @@ -309,7 +309,8 @@ int r8712_init_drv_sw(struct _adapter *padapter) > if (ret) > return ret; > _r8712_init_xmit_priv(&padapter->xmitpriv, padapter); > - _r8712_init_recv_priv(&padapter->recvpriv, padapter); > + ret = _r8712_init_recv_priv(&padapter->recvpriv, padapter); > + return ret; If statement missing. > memset((unsigned char *)&padapter->securitypriv, 0, > sizeof(struct security_priv)); > timer_setup(&padapter->securitypriv.tkip_timer, regards, dan carpenter
