Re: [PATCH -next] media: vpfe_capture: fix kconfig dependency errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Zeng,

I'm skipping this since the driver will be removed very soon (6.2 if all goes well).

Regards,

	Hans

On 9/26/22 06:37, Zeng Heng wrote:
> CONFIG_VIDEO_DM6446_CCDC & CONFIG_VIDEO_DM355_CCDC
> & CONFIG_VIDEO_DM365_ISIF all depend on feature
> VIDEO_DAVINCI_VPBE_DISPLAY, or the compiler would
> complain build errors as below:
> 
> ld: drivers/staging/media/deprecated/vpfe_capture/dm644x_ccdc.o: in function `ccdc_sbl_reset':
> /home/zengheng/linux-next/drivers/staging/media/deprecated/vpfe_capture/dm644x_ccdc.c:238: undefined reference to `vpss_clear_wbl_overflow'
> ld: /home/zengheng/linux-next/drivers/staging/media/deprecated/vpfe_capture/dm644x_ccdc.c:238: undefined reference to `vpss_clear_wbl_overflow'
> ld: /home/zengheng/linux-next/drivers/staging/media/deprecated/vpfe_capture/dm644x_ccdc.c:238: undefined reference to `vpss_clear_wbl_overflow'
> ld: drivers/staging/media/deprecated/vpfe_capture/dm355_ccdc.o: in function `ccdc_restore_defaults':
> /home/zengheng/linux-next/drivers/staging/media/deprecated/vpfe_capture/dm355_ccdc.c:175: undefined reference to `vpss_select_ccdc_source'
> ld: /home/zengheng/linux-next/drivers/staging/media/deprecated/vpfe_capture/dm355_ccdc.c:180: undefined reference to `vpss_enable_clock'
> ld: drivers/staging/media/deprecated/vpfe_capture/dm355_ccdc.o: in function `ccdc_close':
> /home/zengheng/linux-next/drivers/staging/media/deprecated/vpfe_capture/dm355_ccdc.c:196: undefined reference to `vpss_enable_clock'
> ld: drivers/staging/media/deprecated/vpfe_capture/isif.o: in function `isif_restore_defaults':
> /home/zengheng/linux-next/drivers/staging/media/deprecated/vpfe_capture/isif.c:252: undefined reference to `vpss_enable_clock'
> ld: /home/zengheng/linux-next/drivers/staging/media/deprecated/vpfe_capture/isif.c:253: undefined reference to `vpss_enable_clock'
> ld: /home/zengheng/linux-next/drivers/staging/media/deprecated/vpfe_capture/isif.c:254: undefined reference to `vpss_enable_clock'
> ld: /home/zengheng/linux-next/drivers/staging/media/deprecated/vpfe_capture/isif.c:257: undefined reference to `vpss_select_ccdc_source'
> ld: drivers/staging/media/deprecated/vpfe_capture/isif.o: in function `isif_config_raw':
> /home/zengheng/linux-next/drivers/staging/media/deprecated/vpfe_capture/isif.c:680: undefined reference to `dm365_vpss_set_sync_pol'
> ld: /home/zengheng/linux-next/drivers/staging/media/deprecated/vpfe_capture/isif.c:683: undefined reference to `dm365_vpss_set_pg_frame_size'
> ld: /home/zengheng/linux-next/drivers/staging/media/deprecated/vpfe_capture/isif.c:684: undefined reference to `vpss_select_ccdc_source'
> 
> Signed-off-by: Zeng Heng <zengheng4@xxxxxxxxxx>
> ---
>  drivers/staging/media/deprecated/vpfe_capture/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/media/deprecated/vpfe_capture/Kconfig b/drivers/staging/media/deprecated/vpfe_capture/Kconfig
> index 10250e7e566b..557603b51b3f 100644
> --- a/drivers/staging/media/deprecated/vpfe_capture/Kconfig
> +++ b/drivers/staging/media/deprecated/vpfe_capture/Kconfig
> @@ -5,6 +5,7 @@ config VIDEO_DM6446_CCDC
>  	depends on VIDEO_DEV
>  	depends on ARCH_DAVINCI || COMPILE_TEST
>  	depends on I2C
> +	depends on VIDEO_DAVINCI_VPBE_DISPLAY
>  	select VIDEOBUF_DMA_CONTIG
>  	help
>  	  Enables DaVinci CCD hw module. DaVinci CCDC hw interfaces
> @@ -25,6 +26,7 @@ config VIDEO_DM355_CCDC
>  	depends on VIDEO_DEV
>  	depends on ARCH_DAVINCI || COMPILE_TEST
>  	depends on I2C
> +	depends on VIDEO_DAVINCI_VPBE_DISPLAY
>  	select VIDEOBUF_DMA_CONTIG
>  	help
>  	  Enables DM355 CCD hw module. DM355 CCDC hw interfaces
> @@ -45,6 +47,7 @@ config VIDEO_DM365_ISIF
>  	depends on VIDEO_DEV
>  	depends on ARCH_DAVINCI || COMPILE_TEST
>  	depends on I2C
> +	depends on VIDEO_DAVINCI_VPBE_DISPLAY
>  	select VIDEOBUF_DMA_CONTIG
>  	help
>  	  Enables ISIF hw module. This is the hardware module for




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux