On Thu, Oct 20, 2022 at 4:49 PM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Sun, Oct 16, 2022 at 12:07:40PM +0100, Peter Robinson wrote: > > Provide a TODO file that lists the tasks that should be carried out in > > order to move this driver off drivers/staging. It's missing from original > > addition of this driver. > > > > Signed-off-by: Peter Robinson <pbrobinson@xxxxxxxxx> > > --- > > drivers/staging/rtl8192u/TODO | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > create mode 100644 drivers/staging/rtl8192u/TODO > > > > diff --git a/drivers/staging/rtl8192u/TODO b/drivers/staging/rtl8192u/TODO > > new file mode 100644 > > index 000000000000..ab9d5d145b3b > > --- /dev/null > > +++ b/drivers/staging/rtl8192u/TODO > > @@ -0,0 +1,16 @@ > > +To-do list: > > + > > +* Correct the coding style according to Linux guidelines; please read the document > > + at https://www.kernel.org/doc/html/latest/process/coding-style.html. > > +* Remove unnecessary debugging/printing macros; for those that are still needed > > + use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()). > > +* Remove dead code such as unusued functions, variables, fields, etc.. > > +* Use in-kernel API and remove unnecessary wrappers where possible. > > +* Fix bugs due to code that sleeps in atomic context. > > +* Remove the HAL layer and migrate its functionality into the relevant parts of > > + the driver. > > +* Switch to use LIB80211. > > +* Switch to use MAC80211. > > +* Switch to use CFG80211. > > +* Improve the error handling of various functions, particularly those that use > > + existing kernel APIs. > > Where did this list come from? > > How do you know they are all needed? It was based on the other real tek drivers that has a todo and some grep.
