On Wed, Oct 19, 2022 at 11:35 PM Nam Cao <namcaov@xxxxxxxxx> wrote: > > On Wed, Oct 19, 2022 at 07:20:11PM +0000, Tanjuate Brunostar wrote: > > Code style warnings reported by checkpatch. > > Improve the layout of a function header: > > Put the first parameter immediately after the '(' and align the other > > parameters underneath it. > > > > Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@xxxxxxxxx> > > > > --- > > v2: put static and void on the same line and adjusted the indentation as > > suggested by Greg KH > > I think he meant putting "static" and "void" and also function name on > the same line. > Oh I will do this now. thanks > Additionally, I think your patch introduces new checkpatch problems. Did > you run checkpatch.pl on your patch? > > Best regards, > Nam > Yes I did. the checkpatch says this: Alignment should match open parenthesis #89: FILE: drivers/staging/vt6655/rxtx.c:89: +static void s_vFillRTSHead(struct vnt_private *pDevice, + unsigned char byPktType, The only way to resolve this would be to add white space which would generate another checkpatch problem. how do i fix this please?