On Tue, Oct 18, 2022 at 07:12:45PM +0200, Greg KH wrote: > On Tue, Oct 18, 2022 at 10:19:21PM +0530, Deepak R Varma wrote: > > The function dim_get_channel_state only serves to initialize the ready and > > done_buffers fields of the structure passed as its second argument. In > > service_done_flag, this structure is never used again and the only purpose > > of the call is to get the value that is put in the done_buffers field. > > But that value is just the done_sw_buffers_number field of the call's > > first argument. So the whole call is useless, and we can just replace it > > with an access to this field. > > > > This change implies that the variable st is no longer used, so drop it as > > well. > > > > Signed-off-by: Deepak R Varma <drv@xxxxxxxxx> > > --- > > > > PLEASE NOTE: > > 1. I have only built the module on my machine, but have not tested it. > > I am not sure how to test this change. I am willing to test it with > > appropriate guidance provided I have the necessary hardware. > > 2. This was a standalone patch earlier. It is now combined into a patch set > > with another patch for the same driver. Hence I am carry forwarding the > > change log for this patch here: > > > > Changes in v3: > > 1. The patch log message is further improved. This revised verbiage is as > > thankfully provided by julia.lawall@xxxxxxxx > > > > Changes in v2: > > 1. Update patch log message to be more descriptive about the reason for change. > > Feedback provided by julia.lawall@xxxxxxxx > > > > You need to say this is a v3 in the subject line as documented :( > Hi Greg, This was a standalone patch earlier and first time included in the patch set. I was not aware I am allowed to version a patch individually, different from the cover letter. I have posted a query to Outreachy mailing list for additional clarification. I will send in a v4 once I have clarity. Thank you, ./drv
