At 2022-10-10 02:21:46, "Greg KH" <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>On Sun, Oct 09, 2022 at 02:56:47PM +0800, Jiangshan Yi wrote:
>> From: Jiangshan Yi <yijiangshan@xxxxxxxxxx>
>
>Then why is this being sent from a 163.com address?
>
>What is wrong with using your real mail server?
There is a problem with the company's mailbox, and sometimes I can't receive emails. So I temporarily use my personal mailbox to send patches, so that I can receive feedback from the community in a timely manner.
>> @@ -1656,7 +1656,7 @@ u8 rtw_c2h_packet_wk_cmd(struct adapter *padapter, u8 *pbuf, u16 length)
>> return res;
>> }
>>
>> -/* dont call R/W in this function, beucase SDIO interrupt have claim host */
>> +/* don't call R/W in this function, because SDIO interrupt have claim host */
>
>That is not a spelling fix, but rather a "punctuation" fix if you want
>to be picky :)
The patch does s/beucase/because/ and s/dont/don't/.
Follow Documentation/process/coding-style.rst，something write like this:
---------------------------------------
Kernel developers like to be seen as literate. Do mind the spelling
of kernel messages to make a good impression. Do not use incorrect
contractions like ``dont``; use ``do not`` or ``don't`` instead. Make the
messages concise, clear, and unambiguous.
---------------------------------------
So does the comment.
>> /* or deadlock will happen and cause special-systemserver-died in android */
>> u8 rtw_c2h_wk_cmd(struct adapter *padapter, u8 *c2h_evt)
>> {
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
>> index 06e727ce9cc2..71800917d132 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
>> @@ -277,7 +277,7 @@ bool bPseudoTest)
>> return bResult;
>> }
>>
>> -/* 11/16/2008 MH Write one byte to reald Efuse. */
>> +/* 11/16/2008 MH Write one byte to real Efuse. */
>
>The date should just be removed entirely, right?
You're right.
thanks,
Jiangshan Yi
