On Wed, Oct 05, 2022 at 04:10:44PM +0000, Brent Pappas wrote: > Replace function-like macros "HB" and "LB" with static inline functions > to comply with preferred Linux coding style standards. > > Signed-off-by: Brent Pappas <pappasbrent@xxxxxxxxxxxxxxx> > --- > diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c > index 1d1fe8bff7ee..8a8fbc274b73 100644 > --- a/drivers/staging/most/net/net.c > +++ b/drivers/staging/most/net/net.c > @@ -36,8 +36,8 @@ > #define PMS_TELID_MASK 0x0F > #define PMS_TELID_SHIFT 4 > > -#define HB(value) ((u8)((u16)(value) >> 8)) > -#define LB(value) ((u8)(value)) > +static inline u8 HB(unsigned int value) { return ((u8)((u16)(value) >> 8)); } > +static inline u8 LB(unsigned int value) { return ((u8)(value)); } > > #define EXTRACT_BIT_SET(bitset_name, value) \ > (((value) >> bitset_name##_SHIFT) & bitset_name##_MASK) I cannot apply your patch. I think your email client modified some whitespace characters. Check this for more information: https://www.kernel.org/doc/html/v4.10/process/email-clients.html Best regards, Nam