On 9/27/22 08:24, Joash Naidoo wrote:
Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
On Mon, Sep 19, 2022 at 03:23:10PM +0200, Joash Naidoo wrote:
Coding style fix. Fix too many leading tabs and line length.
Signed-off-by: Joash Naidoo <joash.n09@xxxxxxxxx>
---
Changes in v3:
- Fix flipped condition mistake
- move skb NULL check before dereferencing it
Changes in v2:
- Flip additional nested if conditions and don't reverse the
last if statement
- Move declarations to start of function
- Separate converting __constant_htons to htons to another patch
Always test-build your changes before sending them out so you do not get
grumpy emails from maintainers asking why you didn't test-build your
changes...
thanks,
greg k-h
Hi Greg,
Indeed building and testing is a vital step before sending
changes. Is this message referring to my V3 patch not building? Or
referring to my earlier versions?
Hi Joash,
v3 introduces a gcc warning.
drivers/staging/r8188eu/core/rtw_br_ext.c: In function 'dhcp_flag_bcast':
drivers/staging/r8188eu/core/rtw_br_ext.c:606:9: warning: ISO C90
forbids mixed declarations and code [-Wdeclaration-after-statement]
606 | __be16 protocol = *((__be16 *)(skb->data + 2 * ETH_ALEN));
| ^~~~~~
regards,
Michael
