Hi,
On 9/12/22 13:43, Andy Shevchenko wrote:
> On Sun, Sep 11, 2022 at 07:16:52PM +0200, Hans de Goede wrote:
>> atomisp_source_pad_to_stream_id() returns ATOMISP_INPUT_STREAM_GENERAL
>> unconditionally now. Drop it and directly use ATOMISP_INPUT_STREAM_GENERAL
>> in its callers.
>
> ...
>
>> - atomisp_css_capture_enable_online(asd, stream_index, false);
>> + atomisp_css_capture_enable_online(
>> + asd, ATOMISP_INPUT_STREAM_GENERAL, false);
>
> asd can be left on the same line. no?
Right, I changed this to make checkpatch happy about the arguments not being aligned
the same way as the first argument. But then it complained about a '(' at the end of
the line ... so this was not really better (nor worse).
I have changed this to:
atomisp_css_capture_enable_online(asd,
AOMISP_INPUT_STREAM_GENERAL,
false);
now which does make checkpatch fully happy. I will change other 2 blocks in the same way.
Regards,
Hans
>
>
> ...
>
>> + ret = atomisp_css_copy_get_output_frame_info(
>> + asd, ATOMISP_INPUT_STREAM_GENERAL, output_info);
>
> Ditto.
>
> ...
>
>> - atomisp_css_input_set_effective_resolution(isp_sd, stream_id,
>> + atomisp_css_input_set_effective_resolution(
>> + isp_sd, ATOMISP_INPUT_STREAM_GENERAL,
>> crop[pad]->width, crop[pad]->height);
>
> In the similar way...
>
