On Sat, Sep 17, 2022 at 06:24:53AM +0200, Philipp Hortmann wrote: > Remove "Unnecessary ftrace-like logging" as requested by checkpatch. To > keep the logging would make future patches for fixing CamelCase larger. > > Tested with rtl8192e > Transferred this patch over wlan connection of rtl8192e > Looks good. Thanks! Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> When I'm reviewing a mass delete change like this, the typical bug that I'm looking for is deleting extra lines by mistake. So I go through it line by line and make sure nothing extra was deleted. It's not complicated but it just takes a while to check. This patchset will introduce some checkpatch warnings about extra curly braces but I actually prefer if those are fixed in a separate patch. It makes these easier to review. If you were just deleting one RT_TRACE() call then doing it together is the correct thing but when it's a mass delete I prefer the curly braces changes done as a separate thing. regards, dan carpenter
