On Wed, Aug 24, 2022 at 08:03:50AM +0000, cgel.zte@xxxxxxxxx wrote: > From: Minghao Chi <chi.minghao@xxxxxxxxxx> > > container_of is never null, so this null check is > unnecessary. > I can't Ack a patch with this commit message because container_of() *CAN* be NULL. Here, it requires two things: 1) That ->list is the first struct member of struct wlan_network which is true. 2) That "pmlmepriv->pscanned" is NULL. Which I have not looked at. It's really ugly to check container_of() for NULL but some people do it deliberately. Some people also will add a build time assert to ensure that ->list is always the first element so that the check always works. regards, dan carpenter
