On Fri, Aug 19, 2022 at 03:49:35PM +0200, Nam Cao wrote: > because this function is not used. > > Signed-off-by: Nam Cao <namcaov@xxxxxxxxx> This patch is fine, but in the future can you please treat the subject as separate from the commit message. "because it is not used" is a sucky commit message. What is not used? What are you doing to it? It doesn't start with a capital letter. Here is how your email looks like on lore. https://lore.kernel.org/all/7ff2d658863db4fd5eecc1a53f682510c2765c3f.1660916523.git.namcaov@xxxxxxxxx/ Try to find the subject in the middle of the block of text. People are often only going to read the body of the email. [PATCH v2 1/8] staging: rtl8723bs: remove rtw_odm_dbg_comp_msg() The rtw_odm_dbg_comp_msg() function is not used. Delete it. Signed-off-by: regards, dan carpenter
