Re: [PATCH 1/3] staging: r8188eu: set firmware path in a macro

Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx> · Thu, 4 Aug 2022 22:11:58 +0200

On 8/4/22 00:28, Grzegorz Szymaszek wrote:

diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c
index 5bd3022e4b40..5985054da935 100644
--- a/drivers/staging/r8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/r8188eu/os_dep/os_intfs.c
@@ -18,7 +18,7 @@ MODULE_LICENSE("GPL");
  MODULE_DESCRIPTION("Realtek Wireless Lan Driver");
  MODULE_AUTHOR("Realtek Semiconductor Corp.");
  MODULE_VERSION(DRIVERVERSION);
-MODULE_FIRMWARE("rtlwifi/rtl8188eufw.bin");
+MODULE_FIRMWARE(FW_RTL8188EU);
  
  #define CONFIG_BR_EXT_BRNAME "br0"
  #define RTW_NOTCH_FILTER 0 /* 0:Disable, 1:Enable, */


It failed to apply your patch as the following line:
MODULE_FIRMWARE("rtlwifi/rtl8188eufw.bin");
is not in the repo. Inserted line in my repo to apply patch.

Why is the coverletter missing?

Tested all three patches.

Tested-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx> # Edimax N150










