On Thu, Jul 28, 2022 at 07:25:15AM +0200, Martin Kaiser wrote: > Thus wrote Greg Kroah-Hartman (gregkh@xxxxxxxxxxxxxxxxxxx): > > > On Sun, Jul 24, 2022 at 05:39:13PM +0200, Martin Kaiser wrote: > > > Define a struct ieee80211_mgmt in the OnAssocRsp function. Read the > > > destination address (da) from this struct. > > > This explains (sortta) what this patch does, but not why you are doing > > this. > > There's a bunch of macros and functions in the r8188eu driver to parse > standard messages. I'm trying to replace these driver-specific versions > with the generic ones that are shared between several drivers. > > This patch removs one get_da call. It's not much but hopefully, we can > eventually remove get_da itself. > > I know that we should leave the parsing of messages to mac80211 and get > rid of OnAssocRsp etc. Until we're at this point, I hope that doing the > parsing ourselves and using the generic helpers is a useful intermediate > step. > > Would it make sense to rewrite the patch description or to summarize the > patches in this series to something like "read some response message > fields from struct ieee80211_mgmt"? As is, the patch description is not acceptable, so yes, it needs to change :) thanks, greg k-h
