Hi Thomas,
On Mon, Jul 18, 2022 at 9:24 AM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
> Remove firmware devices on the PCI bus, by calling
> aperture_remove_conflicting_pci_devices() in the probe function of
> each related fbdev driver. iSo far, most of these drivers did not
> remove conflicting VESA or EFI devices, or outride failed for
> resource conflicts (i.e., matroxfb.) This must have been broken
> for quite some time.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/video/fbdev/tgafb.c
> +++ b/drivers/video/fbdev/tgafb.c
> @@ -12,6 +12,7 @@
> * more details.
> */
>
> +#include <linux/aperture.h>
> #include <linux/bitrev.h>
> #include <linux/compiler.h>
> #include <linux/delay.h>
> @@ -106,6 +107,12 @@ static struct pci_driver tgafb_pci_driver = {
> static int tgafb_pci_register(struct pci_dev *pdev,
> const struct pci_device_id *ent)
> {
> + int ret;
> +
> + ret = aperture_remove_conflicting_pci_devices(pdev, "tgafb");
> + if (ret)
> + return ret;
> +
> return tgafb_register(&pdev->dev);
> }
I am wondering which driver could possibly conflict with TGA?
Probably there are a few other drivers in the same category (tdfxfb?).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
