Hello Thomas, On 7/15/22 13:48, Thomas Zimmermann wrote: [...] >>> + >>> + return aperture_remove_conflicting_devices(base, size, primary, "sm750_fb1"); >> >> Do you know why this can't just use aperture_remove_conflicting_pci_devices() ? > > I simply don't want change too much at once, because there was this > problem with the PCI helper on ast. > Makes sense. Feel free to add: Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> > At some point we can make a push to really fix this throughout the code > base. And that would include an update to fb_is_primary_device(), [1] > which doesn't fill well into the new interfaces. > Agreed. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
