On Mon, Jun 20, 2022 at 07:55:13PM +0200, Jernej Skrabec wrote:
> Currently error messages when control creation fails are very sparse.
> Granted, user should never observe them. However, developer working on
> codecs can. In such cases additional information like which control
> creation failed and error number are very useful.
>
> Expand error messages with additional info.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
Reviewed-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/staging/media/sunxi/cedrus/cedrus.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c
> index b12219123a6b..99c87319d2b4 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
> @@ -242,7 +242,8 @@ static int cedrus_init_ctrls(struct cedrus_dev *dev, struct cedrus_ctx *ctx)
> v4l2_ctrl_handler_init(hdl, CEDRUS_CONTROLS_COUNT);
> if (hdl->error) {
> v4l2_err(&dev->v4l2_dev,
> - "Failed to initialize control handler\n");
> + "Failed to initialize control handler: %d\n",
> + hdl->error);
> return hdl->error;
> }
>
> @@ -257,7 +258,9 @@ static int cedrus_init_ctrls(struct cedrus_dev *dev, struct cedrus_ctx *ctx)
> NULL);
> if (hdl->error) {
> v4l2_err(&dev->v4l2_dev,
> - "Failed to create new custom control\n");
> + "Failed to create %s control: %d\n",
> + v4l2_ctrl_get_name(cedrus_controls[i].cfg.id),
> + hdl->error);
>
> v4l2_ctrl_handler_free(hdl);
> kfree(ctx->ctrls);
> --
> 2.36.1
>
