On Sat, Jul 09, 2022 at 07:23:20PM -0700, Joe Perches wrote: > On Sat, 2022-07-09 at 19:16 -0700, Binyi Han wrote: > > Fix indentation issue to adhere to Linux kernel coding style. > > Issue found by checkpatch. > > > > Signed-off-by: Binyi Han <dantengknight@xxxxxxxxx> > > --- > > drivers/staging/qlge/qlge_main.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > [] > > @@ -3009,8 +3009,8 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring > > > > for (page_entries = 0; page_entries < > > MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++) > > Probably better to change the for loop to 3 lines as well. > > for (page_entries = 0; > page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); > page_entries++) > > > @@ -3024,8 +3024,8 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring > > > > for (page_entries = 0; page_entries < > > MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++) > > - base_indirect_ptr[page_entries] = > > - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE)); > > + base_indirect_ptr[page_entries] = > > + cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE)); > > etc... > Thanks for the suggestion. Will send a patch v2 in another thread.