On 7/1/22 11:24, Felix Schlepper wrote:
This series addresses some issues raised by chechpatch.pl
and some very minor refactoring.
v2:
- The first version, only addressed coding style issues.
Now, I additionally refactored rtllib_modes and its uses, since
there is no need to use string formatting.
- Logically separated one assignement into two. So we dont have
'fixed' = 'disabled', which was silly.
v3:
- Fixed a checkpatch.pl warning, which was introduced with patch 1/6.
Felix Schlepper (6):
Staging: rtl8192e: Refactored rtllib_modes
Staging: rtl8192e: Avoid multiple assignments
Staging: rtl8192e: Remove unnecessary parentheses
Staging: rtl8192e: Added braces around else
Staging: rtl8192e: Remove unnecessary blank line
Staging: rtl8192e: Added spaces around '+'
drivers/staging/rtl8192e/rtllib_wx.c | 37 +++++++++++-----------------
1 file changed, 15 insertions(+), 22 deletions(-)
Tested-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx>
Sorry for sending one email for each patch. Next time I will just send
one mail for one patch series.
When compiling I saw that the driver is divided into more modules. So
the r8192e_pci.ko is not touched by this patch series.
kernel@matrix-ESPRIMO-P710:~/Documents/git/kernels/staging$ make -C .
M=drivers/staging/rtl8192e
make: Entering directory '/home/kernel/Documents/git/kernels/staging'
CC [M] drivers/staging/rtl8192e/rtllib_wx.o
LD [M] drivers/staging/rtl8192e/rtllib.o
MODPOST drivers/staging/rtl8192e/Module.symvers
CC [M] drivers/staging/rtl8192e/rtllib.mod.o
LD [M] drivers/staging/rtl8192e/rtllib.ko
make: Leaving directory '/home/kernel/Documents/git/kernels/staging'
kernel@matrix-ESPRIMO-P710:~/Documents/git/kernels/staging$ sudo insmod
drivers/staging/rtl8192e/rtllib.ko
kernel@matrix-ESPRIMO-P710:~/Documents/git/kernels/staging$ sudo insmod
drivers/staging/rtl8192e/rtl8192e/r8192e_pci.ko
