Hi Benjamin, On Fri, Jun 17, 2022 at 01:58:00PM +0200, Benjamin Gaignard wrote: > Stop limiting HEVC support to 8-bits bitstreams also > accept 10-bits bitstreams. > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx> > --- > drivers/staging/media/hantro/hantro_hevc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/hantro/hantro_hevc.c b/drivers/staging/media/hantro/hantro_hevc.c > index e06837108a09..85688a4df166 100644 > --- a/drivers/staging/media/hantro/hantro_hevc.c > +++ b/drivers/staging/media/hantro/hantro_hevc.c > @@ -159,8 +159,8 @@ int hantro_hevc_validate_sps(struct hantro_ctx *ctx, const struct v4l2_ctrl_hevc I'd like to go back to checking the SPS control directly in hantro_try_ctrl. I believe the best and most reasonable place to validate the controls would be TRY_CTRL. See https://patchwork.linuxtv.org/project/linux-media/patch/20220629195624.45745-2-ezequiel@xxxxxxxxxxxxxxxxxxxx/. > if (sps->bit_depth_luma_minus8 != sps->bit_depth_chroma_minus8) > /* Luma and chroma bit depth mismatch */ > return -EINVAL; > - if (sps->bit_depth_luma_minus8 != 0) > - /* Only 8-bit is supported */ > + if (sps->bit_depth_luma_minus8 != 0 && sps->bit_depth_luma_minus8 != 2) > + /* Only 8-bit and 10-bit is supported */ Having said that, the change looks good: Reviewed-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx> Thanks, Ezequiel > return -EINVAL; > > ctx->bit_depth = sps->bit_depth_luma_minus8 + 8; > -- > 2.32.0 >
