Re: [PATCH 6/6] i2c: Make remove callback return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Uwe,

Looks good - just one minor change for the mctp-i2c driver, but only
worthwhile if you end up re-rolling this series for other reasons:

> -static int mctp_i2c_remove(struct i2c_client *client)
> +static void mctp_i2c_remove(struct i2c_client *client)
>  {
>         struct mctp_i2c_client *mcli = i2c_get_clientdata(client);
>         struct mctp_i2c_dev *midev = NULL, *tmp = NULL;
> @@ -1000,7 +1000,6 @@ static int mctp_i2c_remove(struct i2c_client *client)
>         mctp_i2c_free_client(mcli);
>         mutex_unlock(&driver_clients_lock);
>         /* Callers ignore return code */
> -       return 0;
>  }

The comment there no longer makes much sense, I'd suggest removing that
too. Either way:

Reviewed-by: Jeremy Kerr <jk@xxxxxxxxxxxxxxxxxxxx>

Cheers,


Jeremy





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux