On Fri, Jun 24, 2022 at 10:41:42AM +0200, Felix Schlepper wrote: > On 24.06.2022 08:21, Dan Carpenter wrote: > > On Thu, Jun 23, 2022 at 11:20:49PM +0200, Andy Shevchenko wrote: > > > On Thu, Jun 23, 2022 at 10:44 PM Felix Schlepper <f3sch.git@xxxxxxxxxxx> wrote: > > > > > > > > Moved error handling to one common block. > > > > This removes double checking if all txb->fragments[] > > > > were initialized. > > > > The original code worked fine, but this is cleaner. > > > > > > ... > > > > > > > +err_free: > > > > + while (--i >= 0) > > > > > > while (i--) > > > > > > will suffice. > > > > > > > Either one is fine. You prefer this format. I prefer that other > > format. I told Felix he could use either format without expressing any > > bias and he chose my format. That means he loves me more. > > > > regards, > > dan carpenter > Andy's advice is of course much appreciated but I prefer Dan's style <3. > > On another note, the thread is quite messy now, since all my previous > failed attempts to send are now threaded to this one. > How would I go about solving this? Sending another v5 version, the v4 > with [RESEND PATCH v4...] or does this even need any action on my part? Please resend a v5, as I now have 3 different copies of a v4 series in my inbox, which makes no sense at all. Remember, make it obvious as to what to do for those of us who have to handle 1000+ emails a day... thanks, greg k-h
