On Tue, Jun 21, 2022 at 09:52:30PM -0700, Chang Yu wrote:
> Added an identifier name for function definition argument
> 'struct timer_list *' as per checkpatch.pl
>
> Note that for the same line checkpatch.pl will also complain "extern
> should be avoided in .c". I am not very familiar with the codebase
> so I decided not to move the declaration to a header file.
>
> Signed-off-by: Chang Yu <marcus.yu.56@xxxxxxxxx>
> ---
> drivers/staging/r8188eu/core/rtw_recv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
> index 36ea79586992..7e2f5c2f9111 100644
> --- a/drivers/staging/r8188eu/core/rtw_recv.c
> +++ b/drivers/staging/r8188eu/core/rtw_recv.c
> @@ -24,7 +24,7 @@ static u8 rtw_rfc1042_header[] = {
> 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
> };
>
> -void rtw_signal_stat_timer_hdl(struct timer_list *);
> +void rtw_signal_stat_timer_hdl(struct timer_list *t);
This really should be a static function, not a global one like this.
That is the correct fix to make, can you do that as an add-on patch?
thanks,
greg k-h
