Re: [PATCH 4/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WRF_cmd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 13, 2022 at 07:07:33PM -0700, daniel watson wrote:
> From: Daniel Watson <ozzloy@xxxxxxxxxxxxxxxxx>
> 
> name the function rtw_IOL_append_WRF_cmd and call it directly,
  ^^^^^^^^
Where is the first part of the sentence?

> instead of using wrapper macro
> 
> delete wrapper macro, which is not needed
> 
> NOTE: code compiles, not tested on hardware
> 
> Signed-off-by: Daniel Watson <ozzloy@xxxxxxxxxxxxxxxxx>
> 
> staging: r8188eu: remove leading '_' on  _rtw_IOL_append_WRF_cmd
> 
> call rtw_IOL_append_WRF_cmd directly instead of using wrapper macro

This is a better commit message but use a capital C "Call".

> delete wrapper macro, which is not needed
> 
> NOTE: code compiles, not tested on hardware
> 
> Signed-off-by: Daniel Watson <ozzloy@xxxxxxxxxxxxxxxxx>

You have the commit message twice.

regards,
dan carpenter





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux