Re: [PATCH 1/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WB_cmd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 13, 2022 at 07:07:30PM -0700, daniel watson wrote:
> From: Daniel Watson <ozzloy@xxxxxxxxxxxxxxxxx>
> 
> name the function rtw_IOL_append_WB_cmd and call it directly,
> instead of using wrapper macro
> 
> delete wrapper macro, which is not needed
> 
> NOTE: code compiles, not tested on hardware

Don't put this kind of comment in the commit message.  Put it under the
--- cut off line.

> 
> Signed-off-by: Daniel Watson <ozzloy@xxxxxxxxxxxxxxxxx>
> ---
  ^^^
Here.

You don't even really need to tell us that you compiled the code,
because we take that as a given.

regards,
dan carpenter






[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux