Re: [PATCH 00/40] media: atomisp: Various hmm and other cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 14, 2022 at 11:50:32AM +0200, Hans de Goede wrote:
> On 6/14/22 11:25, Andy Shevchenko wrote:
> > On Mon, Jun 13, 2022 at 9:51 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:

> > For patches 9-13: I believe that patch 10 and 9 should be swapped in
> > the series. Logically you drop caller first followed by (unused)
> > callee.
> 
> Note the code removed in patch 9 was never called even before patch 10,
> the removed calls in patch 10 were already "#if 0"-ed out. So there
> is no bisect breakage here. With that said I get your point.

Yes, it's not about bisecting, but rather logic and (quite unlike) possibility
of restoring that partially and when someone switches 0 to 1 in those #if:s,
compilation will be broken.

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux