On Tue, Jun 14, 2022 at 05:03:30PM +0800, Dongliang Mu wrote: > From: mudongliang <mudongliangabcd@xxxxxxxxx> > > vfree can handle NULL pointer as its argument. > According to coccinelle isnullfree check, remove NULL check > before vfree operation. > > Signed-off-by: mudongliang <mudongliangabcd@xxxxxxxxx> > --- > drivers/staging/r8188eu/os_dep/usb_intf.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c > index 68869c5daeff..bd1c8b4b5c4b 100644 > --- a/drivers/staging/r8188eu/os_dep/usb_intf.c > +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c > @@ -372,8 +372,7 @@ static struct adapter *rtw_usb_if1_init(struct dvobj_priv *dvobj, > free_adapter: > if (pnetdev) > rtw_free_netdev(pnetdev); > - else if (padapter) > - vfree(padapter); > + vfree(padapter); You changed the logic of this code here, please be more careful in the future. Also, you need to use your real name for the signed-off-by and From: line. thanks, greg k-h
