On Tue, May 31, 2022 at 12:16:58PM -0500, Larry Finger wrote: > On 5/31/22 01:40, Phillip Potter wrote: > > > > Hi Larry, > > > > Both patches look good to me, however I've already submitted a patch 10 > > days ago that does exactly what your rtw_xmit.c patch does, in > > addition to fixing the changed error handling semantics for the relevant > > function (in f94b47c6bde6) which broke the driver. > > Phil, > > Sorry I missed your patch. I have been really busy the past month on another > problem, and I was not paying much attention to r8188eu. > > When I built a mainline kernel in the middle of the merge from 5.18 to 5.19, > those two warnings stood out. > > Your patch should be ahead of mine in Greg's queue, thus mine should fail, > and I will get the "does not apply" message. At that time, I will send the > other patch. As both of us missed the 5.19 merge, the build warnings will > persist until 5.20, but no harm. > > Larry > Please don't be sorry - just wanted you to know in advance :-). Figured if I said nothing I would probably aggravate the situation. I don't have much time to spend on r8188eu myself either so don't worry. All the best, Phil