On 5/21/22 15:26, Pavel Skripkin wrote:
Hi Martin,
On 5/21/22 18:50, Martin Kaiser wrote:
for (i = 0; i < 4; i++)
@@ -1474,7 +1479,7 @@ s32 rtw_xmit_classifier(struct adapter *padapter,
struct xmit_frame *pxmitframe)
res is still 0 here - but the caller of _rtw_init_xmit_priv compares
this return value with _SUCCESS (1) or _FAIL (0) and interprets it as
_FAIL.
I think, it's time to make
s/_SUCCESS/0/
s/_FAIL/-1
since developers from outside of staging are confused.
The main problem will be with functions that return an int (or s32).
Will take a look.
I agree; however, this change will likely break a lot of pending patches.
@GregKH: Could you apply all pending patches in preparation for this patch? If
so, then Pavel could make this transformation while the list is relatively idle.
Larry
