On Sat, May 21, 2022 at 08:53:42AM -0400, Srivathsan Sivakumar wrote: > I've condensed the three dev_dbg() lines into one as you requested in the > previous patch thread; and sent them all as a singular patch. This does not need to be in a changelog text. > fix the following checkpatch.pl warning: > WARNING: Unnecessary ftrace-like logging - prefer using ftrace > > Signed-off-by: Srivathsan Sivakumar <sri.skumar05@xxxxxxxxx> > > Changes in v2: > - Condense three dev_dbg() code lines into one > --- The --- line needs to be right below the signed-off-by line as that is where git will cut the changelog at. You don't want the changelog in the commit. > drivers/staging/rts5208/spi.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/staging/rts5208/spi.c b/drivers/staging/rts5208/spi.c > index f1e9e80044ed..ea736a73e58c 100644 > --- a/drivers/staging/rts5208/spi.c > +++ b/drivers/staging/rts5208/spi.c > @@ -460,10 +460,7 @@ int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip) > spi->clk_div = ((u16)(srb->cmnd[4]) << 8) | srb->cmnd[5]; > spi->write_en = srb->cmnd[6]; > > - dev_dbg(rtsx_dev(chip), "%s: ", __func__); > - dev_dbg(rtsx_dev(chip), "spi_clock = %d, ", spi->spi_clock); > - dev_dbg(rtsx_dev(chip), "clk_div = %d, ", spi->clk_div); > - dev_dbg(rtsx_dev(chip), "write_en = %d\n", spi->write_en); > + dev_dbg(rtsx_dev(chip), "spi_clock = %d, clk_div = %d, write_en = %d\n ", spi->spi_clock, spi->clk_div, spi->write_en); You might want to verify that you really meant to put that many spaces in this line :( thanks, greg k-h
