Hi Pavel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/intel-lab-lkp/linux/commits/Pavel-Skripkin/staging-r8188eu-add-error-handling-of-usb-read-errors/20220519-061342 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git e41f7a5521d7f03dca99e3207633df71740569dd config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220519/202205190916.GRvUby7c-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/f8c9bd199a25d7a1d8f6fed1b0d5da9cec1f8faa git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Pavel-Skripkin/staging-r8188eu-add-error-handling-of-usb-read-errors/20220519-061342 git checkout f8c9bd199a25d7a1d8f6fed1b0d5da9cec1f8faa # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/staging/r8188eu/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/staging/r8188eu/hal/usb_halinit.c: In function '_InitBeaconParameters': >> drivers/staging/r8188eu/hal/usb_halinit.c:465:13: warning: variable 'res' set but not used [-Wunused-but-set-variable] 465 | int res; | ^~~ -- drivers/staging/r8188eu/os_dep/ioctl_linux.c: In function 'rtw_dbg_port': >> drivers/staging/r8188eu/os_dep/ioctl_linux.c:3419:32: warning: variable 'res' set but not used [-Wunused-but-set-variable] 3419 | int i, res; | ^~~ vim +/res +465 drivers/staging/r8188eu/hal/usb_halinit.c 461 462 static void _InitBeaconParameters(struct adapter *Adapter) 463 { 464 struct hal_data_8188e *haldata = &Adapter->haldata; > 465 int res; 466 467 rtw_write16(Adapter, REG_BCN_CTRL, 0x1010); 468 469 /* TODO: Remove these magic number */ 470 rtw_write16(Adapter, REG_TBTT_PROHIBIT, 0x6404);/* ms */ 471 rtw_write8(Adapter, REG_DRVERLYINT, DRIVER_EARLY_INT_TIME);/* 5ms */ 472 rtw_write8(Adapter, REG_BCNDMATIM, BCN_DMA_ATIME_INT_TIME); /* 2ms */ 473 474 /* Suggested by designer timchen. Change beacon AIFS to the largest number */ 475 /* beacause test chip does not contension before sending beacon. by tynli. 2009.11.03 */ 476 rtw_write16(Adapter, REG_BCNTCFG, 0x660F); 477 478 /* FIXME: return an error to caller */ 479 res = rtw_read8(Adapter, REG_FWHW_TXQ_CTRL + 2, &haldata->RegFwHwTxQCtrl); 480 res = rtw_read8(Adapter, REG_TBTT_PROHIBIT + 2, &haldata->RegReg542); 481 res = rtw_read8(Adapter, REG_CR + 1, &haldata->RegCR_1); 482 } 483 -- 0-DAY CI Kernel Test Service https://01.org/lkp
