On Sat, 2022-05-14 at 18:47 +0200, Martin Kaiser wrote: > Replace an if statement with a ternary operator, making the code a tiny > bit shorter. [] > diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c [] > @@ -1503,10 +1503,8 @@ unsigned int OnAction_back(struct adapter *padapter, struct recv_frame *precv_fr > preorder_ctrl->indicate_seq = 0xffff; > preorder_ctrl->enable = pmlmeinfo->bAcceptAddbaReq; > > - if (pmlmeinfo->bAcceptAddbaReq) > - issue_action_BA(padapter, mgmt->sa, WLAN_ACTION_ADDBA_RESP, 0); > - else > - issue_action_BA(padapter, mgmt->sa, WLAN_ACTION_ADDBA_RESP, 37);/* reject ADDBA Req */ > + issue_action_BA(padapter, mgmt->sa, WLAN_ACTION_ADDBA_RESP, > + pmlmeinfo->bAcceptAddbaReq ? 0 : 37); Seems like magic numbers. Maybe add/use defines?