Re: [PATCH v2 1/2] staging: rtl8712: fix uninit-value in usb_read8() and friends

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Setting "data = 0" will silence the KMSAN warnings but it doesn't fix
the bug which is that r8712_usbctrl_vendorreq() treats partial reads
as success.

The usb_control_msg() returns negatives on total failure and it returns
small positives on partial failure.  So take the code that I gave you
before and put that into r8712_usbctrl_vendorreq().  That's patch 1.
These patches become 2 and 3.

        status = usb_control_msg();
        if (status < 0)
                goto free;
        if (status != len) {
                status = -EREMOTEIO;
                goto free;
        }
        if (requesttype == 0x01)
                memcpy(pdata, pIo_buf, status);

regards,
dan carpenter





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux