On Thu, Apr 28, 2022 at 10:15:03AM +0200, Hans Verkuil wrote: > Hi Ian, > > On 25/04/2022 16:41, Ian Cowan wrote: > > This replaces all of the dprintk() macro calls to the zrdev_dbg(), > > zrdev_info(), or zrdev_err() calls as appropriate. This allows for the > > removal of the dprintk() macro from each file it is defined in, along > > with removal of the module params that track the debugging level. > > > > In the case that a debugging level was used in a comparison, this has > > been replaced with checking the console level debugging and making a > > decision from there. If the console debugging level is at least the > > KERN_ debugging level equivalent, then the comparison will evaluate as > > true. > > > > There are a few instances where pr_debug() must be used over the > > zrdev_dbg(). These occur in the module cleanup functions because there > > should be no devices defined once we get to those modules, so we have no > > devices to pass to zrdev_dbg(). > > When I compiled this patch series with smatch I got these warnings: > > zoran/videocodec.c:45 videocodec_attach() warn: variable dereferenced before check 'master' (see line 40) > zoran/videocodec.c:115 videocodec_detach() warn: variable dereferenced before check 'codec' (see line 111) > zoran/videocodec.c:168 videocodec_register() warn: variable dereferenced before check 'codec' (see line 166) > zoran/videocodec.c:200 videocodec_unregister() warn: variable dereferenced before check 'codec' (see line 198) > > And I also got this warning when checking the kerneldoc: > > zoran/zoran.h:307: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > > Can you fix this and post a v3? > > Thanks! > > Hans I will go through and fix these later today. Thanks! Ian
