On Thu, Apr 28, 2022 at 05:23:17PM +0200, Greg Kroah-Hartman wrote: > On Thu, Apr 28, 2022 at 11:05:49AM -0400, Adrien Thierry wrote: > > Replace the custom debug print macros with the standard dev_err() and > > friends. > > > > This handles TODO item "Cleanup logging mechanism". > > > > Signed-off-by: Adrien Thierry <athierry@xxxxxxxxxx> > > --- > > > > Changes since v1: removed function name in dev_dbg() calls > > > > .../interface/vchiq_arm/vchiq_arm.c | 157 +++--- > > .../interface/vchiq_arm/vchiq_connected.c | 7 +- > > .../interface/vchiq_arm/vchiq_connected.h | 4 +- > > .../interface/vchiq_arm/vchiq_core.c | 495 ++++++++---------- > > .../interface/vchiq_arm/vchiq_core.h | 43 +- > > .../interface/vchiq_arm/vchiq_debugfs.c | 105 ---- > > .../interface/vchiq_arm/vchiq_dev.c | 86 ++- > > 7 files changed, 341 insertions(+), 556 deletions(-) > > Try doing this in smaller chunks. There's a lot of churn here, and not > all of it is correct. > > Try removing these one-function-at-a-time and then when it's all > finished, you can remove the debugfs and function calls as no one is > calling them. That is one function you are replacing at a time, not to do this one function you are cleaning up in the source at a time. If that makes sense. Awkward wording...
