Replace macro VNSvInPortD with ioread32.
Avoid cast of the return value as much as possible.
The name of macro and the arguments use CamelCase which
is not accepted by checkpatch.pl
Tested with vt6655 on mini PCI Module
Transferred this patch over wlan connection of vt6655
Used this code for testing of fuction: CARDbGetCurrentTSF in patch
"staging: vt6655: Replace VNSvInPortD with ioread32":
VNSvInPortD(iobase + MAC_REG_TSFCNTR, (u32 *)pqwCurrTSF);
VNSvInPortD(iobase + MAC_REG_TSFCNTR + 4, (u32 *)pqwCurrTSF + 1);
dev_info(&priv->pcid->dev, "CARDbGetCurrentTSF *pqwCurrTSF: %llx", *pqwCurrTSF);
low = ioread32(iobase + MAC_REG_TSFCNTR);
high = ioread32(iobase + MAC_REG_TSFCNTR + 4);
dev_info(&priv->pcid->dev, "CARDbGetCurrentTSF temp_ph: %llx",
low + ((u64)high << 32));
output:
[ +0.000083] vt6655 0000:01:05.0: CARDbGetCurrentTSF *pqwCurrTSF: 116e83
[ +0.000008] vt6655 0000:01:05.0: CARDbGetCurrentTSF temp_ph: 116e83
[ +0.000009] vt6655 0000:01:05.0: CARDbGetCurrentTSF *pqwCurrTSF: 753d80
[ +0.000005] vt6655 0000:01:05.0: CARDbGetCurrentTSF temp_ph: 753d80
[ +0.000010] vt6655 0000:01:05.0: CARDbGetCurrentTSF *pqwCurrTSF: 753d8f
[ +0.000004] vt6655 0000:01:05.0: CARDbGetCurrentTSF temp_ph: 753d8f
V1 -> V2: Removed patch "staging: vt6655: Replace VNSvInPortW with ioread16"
as it was already accepted.
Joint patch "Replace two VNSvInPortD with ioread64_lo_hi" with
patch "Replace VNSvInPortD with ioread32" and changed ioread64 to
two ioread32 as ioread64 does not work with 32 Bit computers.
Shorted and simplified patch descriptions.
V2 -> V3: Added missing version in subject lines
Added change history in cover letter
Removed remark in cover letter "This patch series is new.."
as it is obsolet.
Philipp Hortmann (3):
staging: vt6655: Replace MACvReadMIBCounter with VNSvInPortD
staging: vt6655: Replace MACvReadISR with VNSvInPortD
staging: vt6655: Replace VNSvInPortD with ioread32
drivers/staging/vt6655/card.c | 6 ++++--
drivers/staging/vt6655/device_main.c | 6 +++---
drivers/staging/vt6655/mac.h | 24 +++++++++---------------
drivers/staging/vt6655/rf.c | 2 +-
drivers/staging/vt6655/upc.h | 3 ---
5 files changed, 17 insertions(+), 24 deletions(-)
--
2.25.1
