The values that are being double negated in this case are booleans to begin with, so the double negation has no effect on the result. Signed-off-by: Ian Cowan <ian@xxxxxxxxxxxxxxxx> --- drivers/staging/fieldbus/dev_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fieldbus/dev_core.c b/drivers/staging/fieldbus/dev_core.c index 5aab734606ea..6766b2b13482 100644 --- a/drivers/staging/fieldbus/dev_core.c +++ b/drivers/staging/fieldbus/dev_core.c @@ -28,7 +28,7 @@ static ssize_t online_show(struct device *dev, struct device_attribute *attr, { struct fieldbus_dev *fb = dev_get_drvdata(dev); - return sprintf(buf, "%d\n", !!fb->online); + return sprintf(buf, "%d\n", fb->online); } static DEVICE_ATTR_RO(online); @@ -39,7 +39,7 @@ static ssize_t enabled_show(struct device *dev, struct device_attribute *attr, if (!fb->enable_get) return -EINVAL; - return sprintf(buf, "%d\n", !!fb->enable_get(fb)); + return sprintf(buf, "%d\n", fb->enable_get(fb)); } static ssize_t enabled_store(struct device *dev, struct device_attribute *attr, -- 2.35.1