Hi Dan, On Mon 25 Apr 22, 12:20, Dan Carpenter wrote: > On Sat, Apr 23, 2022 at 02:01:11PM -0400, Ian Cowan wrote: > > Refactor the cedrus_open() function so that there is only one exit to > > the function instead of 2. This prevents a future change from preventing > > the mutex from being unlocked after a successful exit. > > > > Signed-off-by: Ian Cowan <ian@xxxxxxxxxxxxxxxx> > > No. You are just making the code ugly and complicated for no reason. > > I work in static analysis so I have focussed a lot of attention on > locking bugs. In real life this theory is totally bogus. Single exit > paths only cause bugs, they don't prevent bugs. I'm really surprised by this and honestly it feels a bit dogmatic. It reminds me of CS teachers telling me "gotos are evil and you must never use them". In practice there are many situations where they make the code more readable and don't introduce any significant incertainty. In this instance I don't see what could possible go wrong and I agree it makes the code more readable. Cheers, Paul -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
