Thus wrote Dan Carpenter (dan.carpenter@xxxxxxxxxx): > On Sun, Apr 17, 2022 at 12:22:21PM +0200, Martin Kaiser wrote: > > Use ARRAY_SIZE instead of hard-coding the number of entries in the > > mlme_sta_tbl array. > > Signed-off-by: Martin Kaiser <martin@xxxxxxxxx> > > --- > > drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c > > index abb910f33c1c..973adebdd69c 100644 > > --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c > > +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c > > @@ -404,7 +404,7 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame) > > return; > > index = (le16_to_cpu(hdr->frame_control) & IEEE80211_FCTL_STYPE) >> 4; > > - if (index > 13) > > + if (index > ARRAY_SIZE(mlme_sta_tbl)) > ^ > This is an off by one. Should be >=. The auto builders would have > caught this eventually. Thanks for spotting this, Dan. You're right, the array has 14 elements :-( This has already made it into staging-next, I'll fix it in a new patch. Best regards, Martin > > return; > > fct = mlme_sta_tbl[index]; > regards, > dan carpenter
