Did this patch series get lost? just pinging :) On Wed, Apr 13, 2022 at 11:13 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Tue, Apr 12, 2022 at 06:08:24PM +0200, Fabio M. De Francesco wrote: > > On marted? 12 aprile 2022 17:15:29 CEST Dan Carpenter wrote: > > > On Tue, Apr 12, 2022 at 11:53:42AM +0200, Fabio M. De Francesco wrote: > > > > I didn't suggest a re-write of the commit messages. > > > > > > Yes. That's the problem. If you want to complain about a commit > > > message then you *should* suggest how you would re-write it. Otherwise > > > how are we supposed to read your mind? > > > > Ah, sorry. I had missed that you were asking for a re-write (literally). > > > > Here it is a sort of diff on Vihas' patch: > > > > - [PATCH v2 1/7] staging: r8188eu: drop unnecessary wrapper _rtw_free_cmd_priv > > + [PATCH v2 1/7] staging: r8188eu: drop unnecessary helper _rtw_free_cmd_priv() > > > > - Drop unnecessary wrapper _rtw_free_cmd_priv and move its logic to > > - rtw_free_cmd_priv. > > + Drop unnecessary helper (wrapped function) _rtw_free_cmd_priv() and > > + move its code to the wrapper rtw_free_cmd_priv(). > > > > I kind of feel like the original is better. Why would we want to remove > helper functions? Helper functions are ok. What we don't like are > pointless wrapper functions. The whole motivation for the patch is to > remove wrapper functions and that's what it does. > > regards, > dan carpenter > -- Thanks, Vihas
