On Fri, Apr 15, 2022 at 03:21:35PM +0800, Haowen Bai wrote: > The rtllib_rx_assoc_resp() function has a signedness bug because it's > a declared as a u16 but it return -ENOMEM. When you look at it more > closely it returns a mix of error codes including 0xcafe, -ENOMEM, and > a->status which is WLAN_STATUS_NOT_SUPPORTED_AUTH_ALG. This is a mess. > > Clean it up to just return standard kernel error codes. We can print > out the a->status before returning a regular error code. The printks > in the caller need to be adjusted as well. > > Signed-off-by: Haowen Bai <baihaowen@xxxxxxxxx> > --- > V1->V2: reduce return random value; print its own error message. > V2->V3: change commit message; change s16 -> int. > V3->V4: add message suggested by Dan Carpenter. If you look up what > a->status is, it can only be WLAN_STATUS_NOT_SUPPORTED_AUTH_ALG which > is not worth preserving really. I see 3 different v4 patches. Obviously something went wrong, please submit a new one, and properly number it and say what changed between them all. thanks, greg k-h
