Hi Jaehee,
On 4/19/22 21:19, Jaehee Park wrote:
The free_bss_buf member of pmlmepriv is unused. Remove all related
lines.
Suggested-by: Pavel Skripkin <paskripkin@xxxxxxxxx>
Signed-off-by: Jaehee Park <jhpark1013@xxxxxxxxx>
---
[code snip]
@@ -55,16 +54,6 @@ static int _rtw_init_mlme_priv(struct adapter *padapter)
memset(&pmlmepriv->assoc_ssid, 0, sizeof(struct ndis_802_11_ssid));
- pbuf = vzalloc(MAX_BSS_CNT * (sizeof(struct wlan_network)));
-
- if (!pbuf) {
- res = _FAIL;
- goto exit;
- }
- pmlmepriv->free_bss_buf = pbuf;
-
- pnetwork = (struct wlan_network *)pbuf;
-
for (i = 0; i < MAX_BSS_CNT; i++) {
INIT_LIST_HEAD(&pnetwork->list);
And now kernel will just boom here :)
I am sorry for not noticing that from the beginning, that's my fault.
This pointer is used in very weird way, so let's come back to initial
patch: just remove 'if' before vfree().
Refactoring that place is the separate task
I am again sorry for wrong suggestion,
With regards,
Pavel Skripkin
