Hi Rob, On Tue 19 Apr 22, 08:08, Rob Herring wrote: > On Fri, Apr 15, 2022 at 05:37:06PM +0200, Paul Kocialkowski wrote: > > Some Allwinner devices come with an Image Signal Processor (ISP) that > > allows processing camera data to produce good-looking images, > > especially from raw bayer representations. > > > > The ISP does not have a dedicated capture path: it is fed directly by > > one of the CSI controllers, which can be selected at run-time. > > > > Represent this possibility as a graph connection between the CSI > > controller and the ISP in the device-tree bindings. > > > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx> > > --- > > .../bindings/media/allwinner,sun6i-a31-csi.yaml | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml > > index 53aa6dbe8e2c..1b41a6008195 100644 > > --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml > > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml > > @@ -87,6 +87,20 @@ properties: > > > > additionalProperties: false > > > > + port@2: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > If there are not any custom properties, then use > '/schemas/graph.yaml#/properties/port' and drop the 'properties' below. That's right, nothing specific about it. It just represents an internal FIFO between the different blocks. Thanks, I think this also applies to a number of other bindings I submitted in these series. Paul > > + description: ISP output port > > + > > + properties: > > + reg: > > + const: 2 > > + > > + endpoint: > > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > > + unevaluatedProperties: false > > + > > + additionalProperties: false > > + > > anyOf: > > - required: > > - port@0 > > -- > > 2.35.2 > > > > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
