Re: [PATCH v5] staging: vt6655f: rxtx: Fix Lines should not end with a '('

[Pavel Skripkin <paskripkin@xxxxxxxxx>]

Hi Aliya,

On 4/18/22 21:31, Aliya Rahmani wrote:
> -void
> -s_vFillRTSHead(
> -	struct vnt_private *pDevice,
> -	unsigned char byPktType,
> -	void *pvRTS,
> -	unsigned int cbFrameLength,
> -	bool bNeedAck,
> -	bool bDisCRC,
> -	struct ieee80211_hdr *hdr,
> -	unsigned short wCurrentRate,
> -	unsigned char byFBOption
> -)
> +static void s_vFillRTSHead(struct vnt_private *pDevice,
> +			   unsigned char byPktType,
> +			   void *pvRTS,
> +	                   unsigned int cbFrameLength,
> +                          bool bNeedAck,
> +	                   bool bDisCRC,
> +	                   struct ieee80211_hdr *hdr,
> +	                   unsigned short wCurrentRate,
> +	                   unsigned char byFBOption)

Indenting is wrong here. It should be consistent: 8 spaces should be 
converted to tabs

>   {
>   	unsigned int uRTSFrameLen = 20;
>   
> @@ -601,7 +597,7 @@ s_vFillRTSHead(
>   		if (byFBOption == AUTO_FB_NONE) {
>   			struct vnt_rts_g *buf = pvRTS;
>   			/* Get SignalField, ServiceField & Length */
> -			vnt_get_phy_field(pDevice, uRTSFrameLen,
> +			vnt_get_phy_field(pDevice, uRTSFrameLen
>   					  pDevice->byTopCCKBasicRate,

This won't compile. Please, always build-check your patches before 
sending out.




With regards,
Pavel Skripkin