On 22/04/16 01:57PM, Pavel Skripkin wrote: > Hi Wang, > > On 4/15/22 12:57, Wang Cheng wrote: > > Hi Pavel, thx for your review. > > > > Sorry, this patch is just confined to fixing uninit-values with > > modifying the original code as less as possible. It sounds good to > > refactor r8712_usbctrl_vendorreq() with better API. > > > > I understand your idea, but this will just hide the real problem until > syzbot hit it in different place. So, I believe, it's better to fix the root > case instead of hiding local cases. Of course, I agree on fixing the root case. I will think about replacing APIs properly. thanks, - w
