On Wed, Apr 13, 2022 at 06:16:58PM -0700, Joe Perches wrote:
> On Wed, 2022-04-13 at 16:11 -0400, Jaehee Park wrote:
> > To comply with the linux coding style, place constants on the right
> > side of the test in comparisons. Issue found with checkpatch.
> > WARNING: Comparisons should place the constant on the right side of
> > the test.
> []
> > diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
> []
> > @@ -1997,19 +1998,19 @@ void _rtw_roaming(struct adapter *padapter, struct wlan_network *tgt_network)
> > else
> > pnetwork = &pmlmepriv->cur_network;
> >
> > - if (0 < rtw_to_roaming(padapter)) {
> > + if (rtw_to_roaming(padapter) > 0) {
>
> Do you think this change is the same test?
>
> What happens if rtw_to_roaming returns 0?
>
Hi Joe, Thank you for your comments.
If the roaming trying times is none it wouldn't need to associate with
ssids. And we wouldn't need to go into this loop.
I think this change is the same-- am I missing something?
Thanks,
Jaehee
> []
>
> > - if (0 < pmlmepriv->to_roaming) {
> > + if (pmlmepriv->to_roaming > 0) {
>
> here too
>
> > continue;
> > } else {
> > rtw_indicate_disconnect(padapter);
>
>
