Hi Larry,
On 4/14/22 18:36, Larry Finger wrote:
On 4/14/22 03:38, Michael Straube wrote:
The local static variable log_version prevents logging the firmware
information more than once, e.g. when the device is unplugged and
plugged again. That is not necessary and complicates the code. Remove
it.
I think the slight complication of the code, one static variable and one if
statement, is worth not spamming the logs. My recollection is that there are
other cases besides unplugging and replugging that lead to the firmware being
reloaded.
What about pr_info_once? Anyway even with old code message printed only
once per driver load
With regards,
Pavel Skripkin
