Re: staging: r8188eu: struct rt_firmware_header issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/14/22 05:14, David Laight wrote:
From: Michael Straube
Sent: 14 April 2022 11:08

On 4/14/22 10:41, David Laight wrote:
From: Michael Straube
Sent: 13 April 2022 20:42

On 4/13/22 18:27, Michael Straube wrote:
Hi all,

I think the rt_firmware_hdr structure in rtw_fw.c has some issues.


struct rt_firmware_hdr {
       /*  8-byte alinment required */

Probably need an __aligned(8) at the bottom then?

I don't see any reason why this is needed. Do I miss something?

Dunno, the comment might be wrong.

Actually, the le16_to_cpu() references require alignment 4 (I think I got that right).

Larry





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux