On mercoled? 13 aprile 2022 21:31:52 CEST Alison Schofield wrote: > On Wed, Apr 13, 2022 at 11:57:20AM -0700, Fabio M. De Francesco wrote: > > On mercoled? 13 aprile 2022 17:38:24 CEST Alison Schofield wrote: > > > On Wed, Apr 13, 2022 at 09:35:53AM +0200, Fabio M. De Francesco wrote: > > > > On mercoled? 13 aprile 2022 08:52:47 CEST Greg Kroah-Hartman wrote: > > > > > On Tue, Apr 12, 2022 at 11:59:01PM +0200, Fabio M. De Francesco > > wrote: > > > > > > The Unisys sub-tree contains three drivers for the "Unisys Secure > > > > Partition" > > > > > > (s-Par(R)): visorhba, visorinput, visornic. > > > > > > > > > > > > They have no maintainers, in fact the only one that is listed in > > > > MAINTAINERS > > > > > > has an unreacheable email address. During 2021 and 2022 several > > patches > > > > have > > > > > > been submitted to these drivers but nobody at Unisys cared of > > reviewing > > > > the > > > > > > changes. Probably, also the "sparmaintainer" internal list of > > > > unisys.com is > > > > > > not anymore read by interested Unisys' engineers. > > > > > > > > > > > > Therefore, remove the ./unisys subdirectory of staging and delete > > the > > > > related > > > > > > entries in the MAINTAINERS, Kconfig, Makefile files. > > > > > > > > > > > > Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx> > > > > > > --- > > > > > > MAINTAINERS | 8 - > > > > > > > > > > You forgot to at least cc: the people/list on the MAINTAINERS entry > > that > > > > > you are removing here, to give them a hint that this is happening in > > > > > case they want to speak up here (and to give us the ability to point > > to > > > > > that years later when they complain they were never notified...) > > > > > > > > Yes, this is a good idea. I'll submit a v2 and add two "Cc:" lines, one > > to > > > > David Kershner and the other to the "sparmaintainer" list at > > unisys.com. > > > > > > There is another contact in the TODO file (last updated 2015 though ;)) > > > Ken Cox <jkc@xxxxxxxxxx> > > > > Hi Alison, Greg, > > > > Thank you very much for noticing that other contact :) > > > > In the last 12 months I have sent several patches for Unisys s-Par drivers > > but I never noticed that other contact simply because I only ever use > > scripts / get_maintainer.pl to find out who and to which lists to send my > > works. > > > > @Greg: > > > > Do you think that we should care of a contact that is no more active since > > 2015 and resubmit a v3 with one more "Cc:" line? I have no problems to > > resubmit, I just want to be sure that this is the right thing to do. > > I didn't see a v2, so confused about a v3. You could simply do a group > reply and add the contact, that'll put a trail in lore. Not my call. > Guessing Greg has a protocol for such removals. Hi Alison, The patch v2 is at https://lore.kernel.org/outreachy/ 20220413080111.13861-1-fmdefrancesco@xxxxxxxxx/T/#u Greg required me to send that v2 because I forgot to Cc the David Kershner and the Unisys internal list. I don't yet know if Greg's protocol for such removals requires to Cc random people taken from a TODO file, people who didn't even care to add themselves to MAINTAINERS, but I'm pretty sure that, if it is so, the only option is to send a v3. In order to make things as Greg requires, I'd better wait for him to respond to my previous email. Again, thanks, Fabio
