On Wed, 13 Apr 2022, Pavel Skripkin wrote: > Hi Mahak, > > On 4/13/22 08:27, Mahak Gupta wrote: > > Else is not necessary after return and break statements, hence remove > > it. > > > > Reported by checkpatch: > > > > WARNING: else is not generally useful after a break or return > > > > Signed-off-by: Mahak Gupta <mahak_g@xxxxxxxxxxxxx> > > [snip] > > > - } > > + /* could be pure B, pure G, or B/G */ > > + if (rtw_is_cckratesonly_included(rate)) > > + return WIRELESS_11B; > > + else if (rtw_is_cckrates_included(rate)) > > + return WIRELESS_11BG; > > + else > > + return WIRELESS_11G; > > This 'else' is after 'return' as well, isn't it? Just wondering what's the > difference between this one and others in this patch Maybe it's nice to have the three options lined up? julia
